Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the origin setting when inference with FCOS3D head #484

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Tai-Wang
Copy link
Member

Due to #283 fixing the inplace operation when adjusting the origin of 3D boxes, initializing CameraInstance3DBoxes will not change the input tensor for center. So we need to input the origin setting (0.5, 0.5, 0.5) again when initializing the 3D boxes at the modified code.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #484 (10e928b) into master (f7356f4) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 10e928b differs from pull request most recent head ddb33c9. Consider uploading reports for the commit ddb33c9 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   50.62%   50.62%           
=======================================
  Files         191      191           
  Lines       14450    14450           
  Branches     2367     2367           
=======================================
  Hits         7315     7315           
  Misses       6643     6643           
  Partials      492      492           
Flag Coverage Δ
unittests 50.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/dense_heads/fcos_mono3d_head.py 13.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7356f4...ddb33c9. Read the comment docs.

@ZwwWayne ZwwWayne merged commit e108340 into open-mmlab:master Apr 27, 2021
@Tai-Wang Tai-Wang deleted the fix_origin branch July 6, 2021 04:43
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* Update: Optimize document

- Minor fixes in styling and grammar
- Add support for Jetson Xavier NX (Tested and worked)
- Add hardware recommendation
- Change JetPack installation guide URL from jp5.0 to jp4.6.1
- Add a note to select "Jetson SDK Components" when using NVIDIA SDK Manager
- Change PyTorch wheel save location
- Add more dependencies needed for torchvision installation. Otherwise installation error
- Simplify torchvision git cloning branch
- Add installation times for torchvision, MMCV, versioned-hdf5, ppl.cv, model converter, SDK libraries
- Delete "snap" from cmake removal as "apt-get purge" is enough
- Add a note on which scenarios you need to append cu da path and libraries to PATH and LD_LIBRARY_PATH
- Simplify MMCV git cloning branch
- Delete "skip if you don't need MMDeploy C/C++ Inference SDK", because that is the only available inference SDK at the moment
- Add more details to object detection demo using C/C++ Inference SDK such as installing MMDetection and converting a model
- Add image of inference result
- Delete "set env for pip" in troubleshooting because this is already mentioned under "installing Archiconda"

Signed-off-by: Lakshantha Dissanayake <lakshanthad@seeed.cc>

* Fix: note style on doc

* Fix: Trim trailing whitespaces

* Update: add source image before inference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants