Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding PWC metafile #485

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented Apr 26, 2021

  • Adding PWC metafile in each model

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #485 (2bc2cef) into master (6942cf9) will decrease coverage by 0.40%.
The diff coverage is n/a.

❗ Current head 2bc2cef differs from pull request most recent head f97a82a. Consider uploading reports for the commit f97a82a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   51.05%   50.65%   -0.41%     
==========================================
  Files         187      191       +4     
  Lines       13799    14452     +653     
  Branches     2238     2366     +128     
==========================================
+ Hits         7045     7320     +275     
- Misses       6277     6640     +363     
- Partials      477      492      +15     
Flag Coverage Δ
unittests 50.65% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/__init__.py 100.00% <0.00%> (ø)
mmdet3d/datasets/custom_3d_seg.py 65.66% <0.00%> (ø)
mmdet3d/models/dense_heads/__init__.py 100.00% <0.00%> (ø)
...et3d/models/dense_heads/anchor_free_mono3d_head.py 68.58% <0.00%> (ø)
mmdet3d/models/dense_heads/fcos_mono3d_head.py 13.10% <0.00%> (ø)
mmdet3d/datasets/s3dis_dataset.py 90.69% <0.00%> (ø)
...det3d/models/dense_heads/base_mono3d_dense_head.py 42.10% <0.00%> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 86.92% <0.00%> (+0.43%) ⬆️
mmdet3d/datasets/pipelines/loading.py 85.03% <0.00%> (+1.21%) ⬆️
mmdet3d/models/detectors/fcos_mono3d.py 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6942cf9...f97a82a. Read the comment docs.

configs/3dssd/metafile.yml Outdated Show resolved Hide resolved
configs/3dssd/metafile.yml Outdated Show resolved Hide resolved
configs/centerpoint/metafile.yml Outdated Show resolved Hide resolved
configs/dynamic_voxelization/metafile.yml Outdated Show resolved Hide resolved
configs/fp16/metafile.yml Show resolved Hide resolved
configs/imvotenet/metafile.yml Show resolved Hide resolved
configs/nuimages/metafile.yml Outdated Show resolved Hide resolved
configs/nuimages/metafile.yml Outdated Show resolved Hide resolved
configs/parta2/metafile.yml Outdated Show resolved Hide resolved
configs/pointpillars/metafile.yml Outdated Show resolved Hide resolved
Architecture:
- SECOND
- Dynamic Voxelization
- Focal Loss
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is focal loss also used in other models?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether the loss should be regarded as a part of architecture?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can omit Focal Loss and SECOND.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sir. Please refer to metafile in fp16, free_anchor, imvotenet, mvxnet, parta2, pointpillars, regnet, second and ssn. Due to the high frequency, I thought focal loss is a common architecture and is written into metafile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice. I have updated the metafiles.

@ZwwWayne ZwwWayne merged commit 86ef23d into open-mmlab:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants