Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Use MMCV MODEL_REGISTRY #495

Merged
merged 7 commits into from
Apr 28, 2021

Conversation

Wuziyi616
Copy link
Contributor

@Wuziyi616 Wuziyi616 commented Apr 27, 2021

Note: this requires MMCV>=1.3.2!

@Wuziyi616 Wuziyi616 requested a review from ZwwWayne April 27, 2021 10:49
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #495 (d5e3ea6) into master (25a1bca) will decrease coverage by 0.00%.
The diff coverage is 96.77%.

❗ Current head d5e3ea6 differs from pull request most recent head 32e7186. Consider uploading reports for the commit 32e7186 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   50.65%   50.64%   -0.01%     
==========================================
  Files         191      188       -3     
  Lines       14452    14450       -2     
  Branches     2366     2366              
==========================================
- Hits         7320     7318       -2     
  Misses       6640     6640              
  Partials      492      492              
Flag Coverage Δ
unittests 50.64% <96.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/builder.py 90.62% <93.75%> (+1.73%) ⬆️
mmdet3d/datasets/builder.py 60.71% <100.00%> (+1.45%) ⬆️
mmdet3d/datasets/pipelines/dbsampler.py 79.86% <100.00%> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 86.92% <100.00%> (ø)
mmdet3d/models/__init__.py 100.00% <100.00%> (ø)
mmdet3d/models/fusion_layers/point_fusion.py 67.02% <100.00%> (ø)
mmdet3d/models/fusion_layers/vote_fusion.py 93.33% <100.00%> (ø)
mmdet3d/models/middle_encoders/pillar_scatter.py 78.04% <100.00%> (ø)
mmdet3d/models/middle_encoders/sparse_encoder.py 75.86% <100.00%> (ø)
mmdet3d/models/middle_encoders/sparse_unet.py 97.70% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a1bca...32e7186. Read the comment docs.

docs/getting_started.md Outdated Show resolved Hide resolved
mmdet3d/__init__.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit d219867 into open-mmlab:master Apr 28, 2021
@Wuziyi616 Wuziyi616 deleted the model_registry branch April 28, 2021 09:24
Wuziyi616 added a commit to Wuziyi616/mmdetection3d that referenced this pull request Apr 28, 2021
revert PR#495 to solve init_weight problem
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* Fix doc common

* Fix bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants