Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix for SUN RGB-D, when creating .pkl files #511

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[Fix] Fix for SUN RGB-D, when creating .pkl files #511

merged 1 commit into from
Apr 30, 2021

Conversation

virusapex
Copy link
Contributor

When reading calibration files, both Rt and K are being stored as Rt values only. This should fix the issue.

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@virusapex
Copy link
Contributor Author

Related to issue #507

@ZwwWayne
Copy link
Collaborator

Hi @virusapex ,
Thanks for your kind PR. Would you like to sign the CLA thus we could merge it?

@virusapex
Copy link
Contributor Author

Hi @virusapex ,
Thanks for your kind PR. Would you like to sign the CLA thus we could merge it?

Done, @ZwwWayne ! Sorry for the delay.

@Tai-Wang Tai-Wang changed the title Fix for SUN RGB-D, when creating .pkl files [Fix] Fix for SUN RGB-D, when creating .pkl files Apr 30, 2021
@ZwwWayne ZwwWayne merged commit 3e2adb5 into open-mmlab:master Apr 30, 2021
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
@RunningLeon
Fix mask test with mismatched device (open-mmlab#511)
0878b8f 
* align mask output to cpu device

* align ncnn ssd output to torch.Tensor type

* --amend
@OpenMMLab-Assistant-007
Copy link

Hi!
@virusapex
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tai-Wang Tai-Wang Tai-Wang approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@virusapex @CLAassistant @ZwwWayne @OpenMMLab-Assistant-007 @Tai-Wang