Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Benchmark PN++ on ScanNet and S3DIS #541

Merged
merged 9 commits into from
May 18, 2021

Conversation

Wuziyi616
Copy link
Contributor

We provide several settings on two datasets with BEST performance among original paper and third-party implementation.

@Wuziyi616 Wuziyi616 added the WIP label May 13, 2021
@Wuziyi616
Copy link
Contributor Author

Stay tuning. Can be finished within this week I think.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #541 (ed539d1) into master (9d852f1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   50.60%   50.69%   +0.09%     
==========================================
  Files         197      197              
  Lines       14865    14874       +9     
  Branches     2418     2419       +1     
==========================================
+ Hits         7522     7541      +19     
+ Misses       6844     6836       -8     
+ Partials      499      497       -2     
Flag Coverage Δ
unittests 50.69% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 91.01% <100.00%> (+0.10%) ⬆️
mmdet3d/core/points/base_points.py 82.38% <0.00%> (+0.10%) ⬆️
mmdet3d/datasets/pipelines/transforms_3d.py 89.89% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d852f1...ed539d1. Read the comment docs.

Copy link
Collaborator

@ZwwWayne ZwwWayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after updating model links and resolving comments. Cheers!

configs/pointnet2/README.md Outdated Show resolved Hide resolved
configs/pointnet2/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZwwWayne Update pre-trained model links. Ready for merge?

@Wuziyi616 Wuziyi616 removed the WIP label May 17, 2021
@ZwwWayne ZwwWayne merged commit 7f3a16a into open-mmlab:master May 18, 2021
@Wuziyi616 Wuziyi616 deleted the pn2_s3dis_benchmark branch May 19, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants