Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add a file and instructions to fix the Lyft dataset #546

Merged
merged 2 commits into from
May 19, 2021

Conversation

yezhen17
Copy link
Collaborator

No description provided.

@yezhen17
Copy link
Collaborator Author

Shall this be included in compatibility or some other doc?

@yezhen17 yezhen17 requested a review from Tai-Wang May 14, 2021 07:36
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #546 (b6fd2df) into master (cff8ca5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   50.69%   50.69%           
=======================================
  Files         197      197           
  Lines       14873    14873           
  Branches     2419     2419           
=======================================
  Hits         7540     7540           
  Misses       6836     6836           
  Partials      497      497           
Flag Coverage Δ
unittests 50.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff8ca5...b6fd2df. Read the comment docs.

@Tai-Wang
Copy link
Member

Shall this be included in compatibility or some other doc?

This change should not affect the name of the converted info file? If this only modifies that raw data, I think the current fix is ok enough.

@yezhen17
Copy link
Collaborator Author

Shall this be included in compatibility or some other doc?

This change should not affect the name of the converted info file? If this only modifies that raw data, I think the current fix is ok enough.

Yes, will not affect info file. I agree.

@ZwwWayne ZwwWayne merged commit b84111d into open-mmlab:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants