-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Adds windows compilation support #551
Conversation
@divyanshj16 Hi, we really appreciate your contribution, and this PR seems to be very helpful for us. Can you kindly sign the CLA above and then we will start to review your modifications? |
@Wuziyi616 I signed the CLA |
@ZwwWayne Can you have a look at this PR? |
The unit test failed. Seems to because the modified GPU ops can't run successfully on Linux platform? |
Almost all of them says operation cancelled. Could it be because of something else? |
If one run failed in CI, all other runs will be canceled. I think we need to find out the reason in that failed run. The error traceback is:
I am not very familiar with CUDA. I will let my teammates look into this problem. |
@Wuziyi616, @ZwwWayne Is there any update on this? |
Hi @divyanshj16 , |
Looks like the conflicts are addressed in different PR. Apologies for delayed response. |
@divyanshj16 No worry! Thank you for pointing us to this solution. Since we have opened a new PR to solve this issue, I will close this PR. |
* fix ncnn test in regression test * update doc * fix docstring
Hi @divyanshj16 !We are grateful for your efforts in helping improve this open-source project during your personal time. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
fixes #169
Here is the summary of the fixes,
int *xx= new int[variable]
- sourcelong long
.source__device__
, otherwise it was throwing errors about undefined EPS.