Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Converting point with specified rt_matrix #556

Merged
merged 3 commits into from
May 26, 2021

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented May 18, 2021

  • Fixing the bug that the specified rt_matrix will be overwritten by fixed constant when converting from lidar to cam, or from cam to lidar, or from lidar to depth, or from depth to lidar.

@wHao-Wu wHao-Wu requested review from Tai-Wang and ZwwWayne May 18, 2021 08:36
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #556 (41bdee4) into master (cff8ca5) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   50.69%   50.76%   +0.06%     
==========================================
  Files         197      197              
  Lines       14873    14927      +54     
  Branches     2419     2430      +11     
==========================================
+ Hits         7540     7577      +37     
- Misses       6836     6851      +15     
- Partials      497      499       +2     
Flag Coverage Δ
unittests 50.76% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/bbox/structures/coord_3d_mode.py 63.12% <50.00%> (-1.85%) ⬇️
mmdet3d/datasets/lyft_dataset.py 71.57% <0.00%> (ø)
mmdet3d/datasets/nuscenes_dataset.py 40.99% <0.00%> (ø)
mmdet3d/datasets/nuscenes_mono_dataset.py 33.33% <0.00%> (ø)
mmdet3d/datasets/s3dis_dataset.py 91.01% <0.00%> (+0.10%) ⬆️
mmdet3d/core/visualizer/show_result.py 66.95% <0.00%> (+2.60%) ⬆️
mmdet3d/apis/inference.py 59.19% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff8ca5...41bdee4. Read the comment docs.

@ZwwWayne ZwwWayne merged commit c3ef75b into open-mmlab:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants