Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add RandomJitterPoints transform #584

Merged
merged 4 commits into from
May 31, 2021

Conversation

Wuziyi616
Copy link
Contributor

This transform function adds random noise to each point in a 3D scene, which is used in the PAConv segmentor's paper. In a word, its functionality is:

points[:, :3] += np.random.randn(points.shape[0], 3) * jitter_std

Current transform function can't achieve this functionality:

  • ObjectNoise adds noise to object points and bboxes, but we don't have bboxes in segmentation task
  • GlobalRotScaleTrans uses a same translation vector to all the points, and also involve bbox

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #584 (10d86ca) into master (e65772d) will increase coverage by 0.07%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   50.86%   50.94%   +0.07%     
==========================================
  Files         197      197              
  Lines       15067    15093      +26     
  Branches     2453     2458       +5     
==========================================
+ Hits         7664     7689      +25     
+ Misses       6893     6891       -2     
- Partials      510      513       +3     
Flag Coverage Δ
unittests 50.94% <88.46%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 90.11% <88.46%> (-0.09%) ⬇️
mmdet3d/core/points/base_points.py 83.52% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65772d...10d86ca. Read the comment docs.

@Wuziyi616 Wuziyi616 changed the title [Enhance] Add RandomJitterPoints transform [Feature] Add RandomJitterPoints transform May 25, 2021
@ZwwWayne ZwwWayne merged commit 25a736f into open-mmlab:master May 31, 2021
@Wuziyi616 Wuziyi616 deleted the random_jitter_transform branch May 31, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants