Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Remove useless param in 3D Seg Dataset classes #607

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

Wuziyi616
Copy link
Contributor

Remove label_weight because it's actually used in the loss function of Model class

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #607 (af29209) into master (d5bddd2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   50.95%   50.92%   -0.03%     
==========================================
  Files         197      197              
  Lines       15076    15056      -20     
  Branches     2452     2444       -8     
==========================================
- Hits         7682     7668      -14     
+ Misses       6887     6884       -3     
+ Partials      507      504       -3     
Flag Coverage Δ
unittests 50.92% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/custom_3d_seg.py 67.53% <100.00%> (+0.03%) ⬆️
mmdet3d/datasets/s3dis_dataset.py 94.66% <100.00%> (+3.65%) ⬆️
mmdet3d/datasets/scannet_dataset.py 87.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bddd2...af29209. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 6c5a320 into open-mmlab:master Jun 1, 2021
@Wuziyi616 Wuziyi616 deleted the fix_seg_dataset branch June 1, 2021 10:51
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* move doc link check to lint ci and add index.rst file check

* fix filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants