[Fix] Fix bg point filter #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuziyi616
reviewed
Jun 1, 2021
configs/3dssd/3dssd_kitti-3d-car.py
Outdated
| @@ -87,8 +87,8 @@ | |||
| ] | |||
|
|
|||
| data = dict( | |||
| samples_per_gpu=4, | |||
| workers_per_gpu=4, | |||
| samples_per_gpu=2, | |||
There was a problem hiding this comment.
This config file seems strange to me. It doesn't have batch_size x num_GPUs in its name (such as 2x8)?
There was a problem hiding this comment.
I forget to modify it, sorry
There was a problem hiding this comment.
What about the filename? Should we change it to something like 3dssd_**4x8**_kitti-3d-car.py?
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 50.92% 50.97% +0.04%
==========================================
Files 197 197
Lines 15056 15057 +1
Branches 2444 2445 +1
==========================================
+ Hits 7668 7675 +7
+ Misses 6884 6878 -6
Partials 504 504
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
reviewed
Jun 6, 2021
ZwwWayne
approved these changes
Jun 6, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue(#347)