Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix LoadMultiViewImageFromFiles to be compatible with DefaultFormatBundle #611

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

Wuziyi616
Copy link
Contributor

Fix issue #227. LoadMultiViewImageFromFiles is currently not used in the codebase. I simply unravel the stacked multi-view img to list because DefaultFormatBundle requires so (see here).

This solution is better than PR #229 I think.

@Wuziyi616 Wuziyi616 changed the title [Fix] Fix LoadMultiViewImageFromFiles as mentioned in issue #227 [Fix] Fix LoadMultiViewImageFromFiles to be compatible with DefaultFormatBundle Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #611 (3e62814) into master (d5bddd2) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   50.95%   51.06%   +0.11%     
==========================================
  Files         197      197              
  Lines       15076    15059      -17     
  Branches     2452     2445       -7     
==========================================
+ Hits         7682     7690       +8     
+ Misses       6887     6865      -22     
+ Partials      507      504       -3     
Flag Coverage Δ
unittests 51.06% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/loading.py 90.61% <100.00%> (+5.57%) ⬆️
mmdet3d/datasets/scannet_dataset.py 87.85% <0.00%> (ø)
mmdet3d/datasets/custom_3d_seg.py 67.53% <0.00%> (+0.03%) ⬆️
mmdet3d/datasets/s3dis_dataset.py 94.66% <0.00%> (+3.65%) ⬆️
mmdet3d/datasets/pipelines/formating.py 60.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5bddd2...3e62814. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants