-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support ImVoxelNet on KITTI #627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 51.04% 51.10% +0.05%
==========================================
Files 201 203 +2
Lines 15221 15307 +86
Branches 2468 2472 +4
==========================================
+ Hits 7770 7822 +52
- Misses 6933 6967 +34
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Just need to fix some minor comments.
In addition, maybe we can inherit the kitti base dataset config in the imvoxelnet config?
I think there are too much point-cloud related transforms and we need only images. Also, do I need to add a unit test? |
OK, then we can keep the current format for configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready to merge except consistent expression of Tensor in the docstring
I will also run training on 8 GPUs one more time to be sure that refactoring Anchor3DGenerator and ConvModule not much influenced anything. |
I reverted anchor ranges, metrics are fine now. Can share model and log if needed. |
Reimplementation of ImVoxelNet for kitti-3d-car