Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Group-Free-3D Benchmark on ScanNet #710

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

hjin2902
Copy link
Contributor

@hjin2902 hjin2902 commented Jul 6, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Release 4 groupfree3d models on ScanNet dataset.

Modification

Publish 4 models on ScanNet dataset and provide README.md.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
No.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hjin2902 hjin2902 requested a review from ZwwWayne July 6, 2021 11:23
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #710 (0899eb1) into master (1f79fc7) will not change coverage.
The diff coverage is n/a.

❗ Current head 0899eb1 differs from pull request most recent head b6ae53e. Consider uploading reports for the commit b6ae53e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   48.93%   48.93%           
=======================================
  Files         208      208           
  Lines       15861    15861           
  Branches     2543     2543           
=======================================
  Hits         7761     7761           
  Misses       7606     7606           
  Partials      494      494           
Flag Coverage Δ
unittests 48.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f79fc7...b6ae53e. Read the comment docs.

@Tai-Wang Tai-Wang changed the title release groupfree3d models on scannet [Enhance] Group-Free-3D Benchmark on ScanNet Jul 7, 2021
@ZwwWayne ZwwWayne merged commit 2f95eb7 into open-mmlab:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants