Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Move bev_range to ObjectRangeFilter's call for consistency with gt_bboxes_3d type #717

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

gopi-erabati
Copy link
Contributor

@gopi-erabati gopi-erabati commented Jul 7, 2021

Motivation

Fix the bev_range initialization in ObjectRangeFilter according to the gt_bboxes_3d type. Closes #716

Modification

The bev_range initialization in ObjectRangeFilter __init__ is moved to __call__ to check the gt_bboxes_3d coordinate system type (like LiDAR or CAM) and initialize it accordingly.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@gopi-erabati gopi-erabati changed the title [Fix] Move bev_range to ObjectRangeFilter's call for consistency with points type [Fix] Move bev_range to ObjectRangeFilter's call for consistency with gt_bboxes_3d type Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #717 (e068523) into master (ea84601) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head e068523 differs from pull request most recent head b1d025e. Consider uploading reports for the commit b1d025e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   48.92%   48.91%   -0.01%     
==========================================
  Files         208      208              
  Lines       15863    15866       +3     
  Branches     2544     2546       +2     
==========================================
  Hits         7761     7761              
- Misses       7607     7609       +2     
- Partials      495      496       +1     
Flag Coverage Δ
unittests 48.91% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/transforms_3d.py 90.85% <50.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea84601...b1d025e. Read the comment docs.

@Wuziyi616 Wuziyi616 requested a review from ZwwWayne July 8, 2021 02:00
@ZwwWayne ZwwWayne merged commit f5cdc7b into open-mmlab:master Jul 12, 2021
@gopi-erabati gopi-erabati deleted the fix-bev-objrangefilter branch July 12, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug in 'bev_range' of ObjectRangeFilter
3 participants