Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix potential bug in using analyze_logs.py #720

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

Wuziyi616
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

A minor error when plotting eval results and interval == 1. If we abort training and then plot curve, the length of x-dim (epoch) and y-dim (some epoch) will be different.

Modification

Check if interval == 1.

BC-breaking (Optional)

No

Use cases (Optional)

N.A

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Wuziyi616 Wuziyi616 requested a review from ZwwWayne July 8, 2021 14:55
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #720 (60f731d) into master (ea84601) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files         208      208           
  Lines       15863    15863           
  Branches     2544     2544           
=======================================
  Hits         7761     7761           
  Misses       7607     7607           
  Partials      495      495           
Flag Coverage Δ
unittests 48.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea84601...60f731d. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 810c44d into open-mmlab:master Jul 13, 2021
@Wuziyi616 Wuziyi616 deleted the analyze_log_bug branch July 13, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants