Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support mim #782

Merged
merged 5 commits into from
Jul 28, 2021
Merged

[Enhance] Support mim #782

merged 5 commits into from
Jul 28, 2021

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented Jul 23, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • Support MIM

@wHao-Wu wHao-Wu changed the title Support mim [Enhance] Support mim Jul 23, 2021
@wHao-Wu wHao-Wu requested a review from ZwwWayne July 23, 2021 02:44
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #782 (b74fea7) into master (1b2e64c) will not change coverage.
The diff coverage is n/a.

❗ Current head b74fea7 differs from pull request most recent head c7c2def. Consider uploading reports for the commit c7c2def to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   48.94%   48.94%           
=======================================
  Files         208      208           
  Lines       15884    15884           
  Branches     2538     2538           
=======================================
  Hits         7774     7774           
  Misses       7608     7608           
  Partials      502      502           
Flag Coverage Δ
unittests 48.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/visualizer/show_result.py 66.38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2e64c...c7c2def. Read the comment docs.

MANIFEST.in Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

May test the compatibility with MIM.

setup.py Outdated Show resolved Hide resolved
@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented Jul 28, 2021

@ZwwWayne @zhouzaida
The test of compatibility between mmdet3d and mim is completed successfully.

Copy link

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 7796487 into open-mmlab:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants