Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Benchmark PAConv on S3DIS dataset #809

Merged
merged 13 commits into from
Jul 31, 2021

Conversation

Wuziyi616
Copy link
Contributor

@Wuziyi616 Wuziyi616 commented Jul 30, 2021

Release PAConv model on S3DIS semantic segmentation task.

Just FYI, the paper's result is 66.33% while ours is 66.65%.

Copy link
Contributor Author

@Wuziyi616 Wuziyi616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZwwWayne checkpoint and log need to be uploaded

@Wuziyi616 Wuziyi616 requested a review from ZwwWayne July 30, 2021 13:51
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #809 (7cecec4) into master (43b4632) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 7cecec4 differs from pull request most recent head bc7ede1. Consider uploading reports for the commit bc7ede1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   49.03%   49.16%   +0.12%     
==========================================
  Files         210      210              
  Lines       15964    15965       +1     
  Branches     2547     2547              
==========================================
+ Hits         7828     7849      +21     
+ Misses       7634     7614      -20     
  Partials      502      502              
Flag Coverage Δ
unittests 49.16% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/pipelines/transforms_3d.py 90.41% <100.00%> (+0.01%) ⬆️
mmdet3d/models/segmentors/encoder_decoder.py 21.98% <0.00%> (+1.04%) ⬆️
mmdet3d/ops/group_points/group_points.py 33.33% <0.00%> (+2.15%) ⬆️
mmdet3d/models/decode_heads/paconv_head.py 56.25% <0.00%> (+12.50%) ⬆️
mmdet3d/ops/pointnet_modules/paconv_sa_module.py 50.79% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b4632...bc7ede1. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 5258fe9 into open-mmlab:master Jul 31, 2021
@Wuziyi616 Wuziyi616 deleted the paconv_benchmark branch July 31, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants