Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix wrap_fp16_model import #861

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

yezhen17
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.
Fix a deprecated import.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@yezhen17 yezhen17 requested a review from ZwwWayne August 11, 2021 00:41
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #861 (839f6fc) into master (31ef559) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage   49.07%   49.32%   +0.25%     
==========================================
  Files         210      210              
  Lines       15961    16019      +58     
  Branches     2547     2556       +9     
==========================================
+ Hits         7833     7902      +69     
+ Misses       7626     7614      -12     
- Partials      502      503       +1     
Flag Coverage Δ
unittests 49.32% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 88.57% <0.00%> (-6.10%) ⬇️
mmdet3d/datasets/__init__.py 100.00% <0.00%> (ø)
mmdet3d/datasets/pipelines/formating.py 60.00% <0.00%> (ø)
mmdet3d/models/detectors/single_stage_mono3d.py 16.66% <0.00%> (ø)
mmdet3d/datasets/pipelines/transforms_3d.py 90.46% <0.00%> (+0.05%) ⬆️
mmdet3d/core/points/base_points.py 85.00% <0.00%> (+1.47%) ⬆️
mmdet3d/core/bbox/structures/coord_3d_mode.py 63.82% <0.00%> (+2.83%) ⬆️
mmdet3d/ops/pointnet_modules/paconv_sa_module.py 74.60% <0.00%> (+23.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ef559...839f6fc. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 90e6378 into open-mmlab:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants