Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_voxel_generator.py #919

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

mickeyouyou
Copy link
Contributor

@mickeyouyou mickeyouyou commented Sep 7, 2021

respect point_to_voxel() return parameter list

    Returns:
        tuple[np.ndarray]:
            voxels: Shape [M, max_points, ndim], only contain points.
            coordinates: Shape [M, 3].
            num_points_per_voxel: Shape [M].

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2021

CLA assistant check
All committers have signed the CLA.

@mickeyouyou
Copy link
Contributor Author

mickeyouyou commented Sep 7, 2021

Force pushed by fix lint errors. thank you all . @ZwwWayne @THU17cyz

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #919 (f30a29a) into master (075f444) will not change coverage.
The diff coverage is n/a.

❗ Current head f30a29a differs from pull request most recent head 4c003c5. Consider uploading reports for the commit 4c003c5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #919   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files         210      210           
  Lines       16021    16021           
  Branches     2556     2556           
=======================================
  Hits         7904     7904           
  Misses       7614     7614           
  Partials      503      503           
Flag Coverage Δ
unittests 49.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075f444...4c003c5. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 807da14 into open-mmlab:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants