Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to build_anchor_generator #941

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Conversation

mickeyouyou
Copy link
Contributor

miniconda3/envs/open-mmlab/lib/python3.7/site-packages/mmdet/core/anchor/builder.py:17: UserWarning: build_anchor_generator would be deprecated soon, please use build_prior_generator

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #941 (7405d6a) into master (21e4b12) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files         210      210           
  Lines       16021    16021           
  Branches     2556     2556           
=======================================
  Hits         7904     7904           
  Misses       7614     7614           
  Partials      503      503           
Flag Coverage Δ
unittests 49.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/anchor/__init__.py 100.00% <100.00%> (ø)
mmdet3d/models/dense_heads/anchor3d_head.py 29.84% <100.00%> (ø)
mmdet3d/models/detectors/imvoxelnet.py 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e4b12...7405d6a. Read the comment docs.

@ZwwWayne ZwwWayne changed the base branch from master to v1.0.0.dev0 September 22, 2021 09:02
@ZwwWayne ZwwWayne changed the base branch from v1.0.0.dev0 to master September 22, 2021 09:02
@ZwwWayne ZwwWayne merged commit b1deeb5 into open-mmlab:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants