-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] Use meta path instead of AST transform to implement new config. #1215
Open
mzr1996
wants to merge
13
commits into
open-mmlab:main
Choose a base branch
from
mzr1996:meta-path-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzr1996
requested review from
Harold-lkk,
HAOCHENYE,
zhouzaida and
RangiLyu
as code owners
June 28, 2023 08:46
mzr1996
force-pushed
the
meta-path-config
branch
4 times, most recently
from
July 11, 2023 10:42
06ceff8
to
74fa267
Compare
mzr1996
force-pushed
the
meta-path-config
branch
3 times, most recently
from
July 18, 2023 01:59
3596af5
to
5646bf0
Compare
mzr1996
force-pushed
the
meta-path-config
branch
from
July 18, 2023 02:02
5646bf0
to
3e3e3e6
Compare
mzr1996
force-pushed
the
meta-path-config
branch
2 times, most recently
from
August 24, 2023 07:11
4364d52
to
d98b733
Compare
mzr1996
force-pushed
the
meta-path-config
branch
from
August 24, 2023 07:48
d98b733
to
b23516b
Compare
HAOCHENYE
reviewed
Aug 28, 2023
mzr1996
force-pushed
the
meta-path-config
branch
from
September 13, 2023 03:48
5c7f143
to
b9af285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the original new config implementation, we use AST transform to manipulate the import statements.
It's a little obscure, and hard to debug.
Modification
Python provide a native feature to override the import behaviors. In this PR, we use
sys.meta_path
toimplement the lazy import and base config file import.
BC-breaking
I have tested on MMPreTrain new config, it shouldn't change the original usages, but please check it carefully.
Checklist