Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix unit test in windows #515

Merged
merged 37 commits into from
Sep 13, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Test windows CI. This PR will be merged to #512

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne requested a review from zhouzaida September 6, 2022 02:42
@ZwwWayne ZwwWayne added this to the 0.2.0 milestone Sep 6, 2022
@HAOCHENYE HAOCHENYE force-pushed the HAOCHENYE/fix_windows_ci branch from 9a40970 to 40c1347 Compare September 6, 2022 09:26
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@ba1c368). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 0896853 differs from pull request most recent head ad23b3b. Consider uploading reports for the commit ad23b3b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage        ?   77.75%           
=======================================
  Files           ?      116           
  Lines           ?     8605           
  Branches        ?     1775           
=======================================
  Hits            ?     6691           
  Misses          ?     1618           
  Partials        ?      296           
Flag Coverage Δ
unittests 77.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HAOCHENYE HAOCHENYE closed this Sep 8, 2022
@zhouzaida zhouzaida reopened this Sep 8, 2022
# Conflicts:
#	.github/workflows/pr_stage_test.yml
#	tests/test_utils/test_dl_utils/test_get_env.py
@HAOCHENYE HAOCHENYE changed the title [WIP] tmp test unit test [Fix] Fix unit test in windows Sep 8, 2022
@zhouzaida
Copy link
Collaborator

This file (tests/test_testing/test_assert_called.py) is empty.

Comment on lines +84 to +87
# `FileHandler` should be closed in Windows, otherwise we cannot
# delete the temporary directory
logging.shutdown()
MMLogger._instance_dict.clear()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a more elegant way to shut down those file handlers in the future?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll provide a TestCase to create and delete global variance.

@ZwwWayne ZwwWayne merged commit 6b1b8a3 into open-mmlab:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants