-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix unit test in windows #515
[Fix] Fix unit test in windows #515
Conversation
9861a6b
to
9a40970
Compare
9a40970
to
40c1347
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=======================================
Coverage ? 77.75%
=======================================
Files ? 116
Lines ? 8605
Branches ? 1775
=======================================
Hits ? 6691
Misses ? 1618
Partials ? 296
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# Conflicts: # .github/workflows/pr_stage_test.yml # tests/test_utils/test_dl_utils/test_get_env.py
This file (tests/test_testing/test_assert_called.py) is empty. |
# `FileHandler` should be closed in Windows, otherwise we cannot | ||
# delete the temporary directory | ||
logging.shutdown() | ||
MMLogger._instance_dict.clear() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a more elegant way to shut down those file handlers in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll provide a TestCase
to create and delete global variance.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Test windows CI. This PR will be merged to #512
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist