[Fix] Fix BaseDataPreprocessor.cast_data cound not handle string data
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine type hint
Codecov ReportBase: 77.91% // Head: 78.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 77.91% 78.10% +0.19%
==========================================
Files 126 126
Lines 9072 9039 -33
Branches 1806 1800 -6
==========================================
- Hits 7068 7060 -8
+ Misses 1691 1666 -25
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mzr1996
previously approved these changes
Oct 13, 2022
C1rN09
previously approved these changes
Oct 13, 2022
zhouzaida
reviewed
Oct 15, 2022
zhouzaida
reviewed
Oct 15, 2022
# Conflicts: # mmengine/model/base_model/data_preprocessor.py
C1rN09
reviewed
Oct 25, 2022
zhouzaida
reviewed
Oct 27, 2022
zhouzaida
approved these changes
Oct 27, 2022
7 tasks
ly015
pushed a commit
to ly015/mmengine
that referenced
this pull request
Nov 9, 2022
…ta (open-mmlab#602) * [Fix] Fix cound not handle string data * Minor refine * Refine type hint Refine type hint * fix as comment * Minor refine * Update mmengine/model/base_model/data_preprocessor.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix
BaseDataPreprocessor.cast_datacound not handle string data to solve #575Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist