-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TTAModel compatible with FSDP. #611
Merged
zhouzaida
merged 50 commits into
open-mmlab:main
from
HAOCHENYE:HAOCHENYE/compatible_with_fsdp
Dec 27, 2022
Merged
Make TTAModel compatible with FSDP. #611
zhouzaida
merged 50 commits into
open-mmlab:main
from
HAOCHENYE:HAOCHENYE/compatible_with_fsdp
Dec 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_with_fsdp # Conflicts: # mmengine/testing/__init__.py
zhouzaida
reviewed
Dec 24, 2022
zhouzaida
reviewed
Dec 24, 2022
zhouzaida
reviewed
Dec 24, 2022
zhouzaida
reviewed
Dec 24, 2022
zhouzaida
reviewed
Dec 24, 2022
zhouzaida
reviewed
Dec 24, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
zhouzaida
reviewed
Dec 25, 2022
It would be better to update the pr message about which repositories have verified this PR and their PR links. |
RangiLyu
reviewed
Dec 26, 2022
Co-authored-by: RangiLyu <lyuchqi@gmail.com>
zhouzaida
previously approved these changes
Dec 27, 2022
RangiLyu
previously approved these changes
Dec 27, 2022
zhouzaida
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
BaseTTAModel
cannot set the device forBaseModel
.DataPreprocessor
could accept non-tensor and non-datasample objects.Related PR:
open-mmlab/mmdetection#9452
open-mmlab/mmsegmentation#2335
open-mmlab/mmpretrain#1161
Modification
BaseTTAModel
inherit fromBaseModel
.build_runner_with_tta
for using FSDP and TTA simultaneously. In this case,BaseTTAModel
should be the wrapper ofFSDPWrapper
.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist