Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Enhance compatibility of revert_sync_batchnorm #695

Merged
merged 11 commits into from
Nov 24, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Resolve #638

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE added the enhancement New feature or request label Nov 17, 2022
@HAOCHENYE HAOCHENYE modified the milestones: 0.4.0, 0.3.2 Nov 17, 2022
zytx121
zytx121 previously approved these changes Nov 22, 2022
Copy link

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 78.45% // Head: 78.67% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (ab0e954) compared to base (bf369da).
Patch coverage: 88.06% of modified lines in pull request are covered.

❗ Current head ab0e954 differs from pull request most recent head bbb2c81. Consider uploading reports for the commit bbb2c81 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   78.45%   78.67%   +0.21%     
==========================================
  Files         126      128       +2     
  Lines        9141     9341     +200     
  Branches     1818     1845      +27     
==========================================
+ Hits         7172     7349     +177     
- Misses       1656     1675      +19     
- Partials      313      317       +4     
Flag Coverage Δ
unittests 78.67% <88.06%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/config/utils.py 58.49% <ø> (ø)
mmengine/dataset/base_dataset.py 98.00% <ø> (ø)
mmengine/hooks/ema_hook.py 93.33% <ø> (ø)
mmengine/hub/hub.py 25.71% <ø> (ø)
mmengine/optim/scheduler/lr_scheduler.py 100.00% <ø> (ø)
mmengine/optim/scheduler/momentum_scheduler.py 100.00% <ø> (ø)
mmengine/utils/__init__.py 100.00% <ø> (ø)
mmengine/hooks/checkpoint_hook.py 89.79% <25.00%> (-0.52%) ⬇️
mmengine/hooks/naive_visualization_hook.py 93.93% <50.00%> (-2.84%) ⬇️
mmengine/optim/optimizer/zero_optimizer.py 57.14% <57.14%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

zhouzaida
zhouzaida previously approved these changes Nov 24, 2022
zhouzaida
zhouzaida previously approved these changes Nov 24, 2022
@zhouzaida zhouzaida changed the title [Enhance] Enhance compatibility of revert_sync_batchnorm and convert_sync_batchnorm [Enhance] Enhance compatibility of revert_sync_batchnorm Nov 24, 2022
@zhouzaida zhouzaida merged commit ded73f3 into open-mmlab:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] error when using python tools/train.py to train ReDet in MMRotate.
3 participants