Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Try to create a symbolic link on windows #37

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

zhouzaida
Copy link
Contributor

Related Issue: open-mmlab/mmdetection#6480

Creating a symbolic link on windows may raise an OSError: [WinError 1314] due to privilege. If the error happens, the src file will be copied.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2021

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida changed the title Try to create symbolic link [Enhancement] Try to create a symbolic link on windows Nov 27, 2021
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeowZheng MeowZheng merged commit 3d71d57 into open-mmlab:master Nov 29, 2021
@zhouzaida zhouzaida deleted the try-to-create-symbolic-link branch November 29, 2021 05:07
MeowZheng pushed a commit that referenced this pull request Jul 15, 2022
* Try to create a symbolic link, otherwise copy

* Improve comment

* Improve comment

* Improve comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants