Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix RAFT wrong refine iter after evaluation #62

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

MeowZheng
Copy link
Collaborator

Motivation

As refine iterations when model testing is different from model training, it used test_cfg to modify iter of the model when testing but forgot to recover the iter for training.

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #62 (0db516d) into master (2f98716) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   66.97%   67.07%   +0.10%     
==========================================
  Files          83       83              
  Lines        4723     4726       +3     
  Branches      678      678              
==========================================
+ Hits         3163     3170       +7     
+ Misses       1457     1453       -4     
  Partials      103      103              
Flag Coverage Δ
unittests 67.07% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/models/flow_estimators/raft.py 83.33% <100.00%> (+0.98%) ⬆️
mmflow/datasets/pipelines/transforms.py 78.66% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef97cdd...0db516d. Read the comment docs.

@MeowZheng MeowZheng merged commit 607e1ed into open-mmlab:master Dec 22, 2021
@MeowZheng MeowZheng deleted the fix-raft-iter branch December 22, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant