Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update NAN files in flyingthings3d_subset #94

Merged
merged 1 commit into from
Feb 18, 2022
Merged

[FIX] Update NAN files in flyingthings3d_subset #94

merged 1 commit into from
Feb 18, 2022

Conversation

lhao0301
Copy link
Contributor

@lhao0301 lhao0301 commented Feb 17, 2022

As title. related issue #88

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution

I'll double-check it today

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #94 (62988c5) into master (6da61bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   68.02%   68.02%           
=======================================
  Files          86       86           
  Lines        4895     4895           
  Branches      705      705           
=======================================
  Hits         3330     3330           
  Misses       1457     1457           
  Partials      108      108           
Flag Coverage Δ
unittests 68.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/datasets/flyingthings3d_subset.py 87.75% <ø> (ø)
mmflow/datasets/pipelines/transforms.py 79.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da61bf...62988c5. Read the comment docs.

@MeowZheng
Copy link
Collaborator

image
I have checked it.

@MeowZheng MeowZheng merged commit b736b79 into open-mmlab:master Feb 18, 2022
@OpenMMLab-Assistant003
Copy link

Hi @lhao0301!First of all, we want to express our gratitude for your significant PR in the MMFlow project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @lhao0301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants