-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Refactor Evaluation for translation models #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 75.28% 75.23% -0.05%
==========================================
Files 121 121
Lines 8189 8190 +1
Branches 1561 1560 -1
==========================================
- Hits 6165 6162 -3
- Misses 1609 1611 +2
- Partials 415 417 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Maybe we should support
online
evaluation intranslation_eval.py
. EvalHook
for translation model should be supported as well.
Of course, the part @LeoXing1996 mentioned is in my plan. I will complete the |
I tested evaluation(include online mode) and inference, and the codes work fine. However, there are some differences between the evaluation results and the previous ones, and I am looking for the reasons. |
@@ -67,19 +67,53 @@ | |||
] | |||
|
|||
dataroot = './data/unpaired_facades' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the file name in this PR and keep them consistent with others in MMGEN. The major problem is that in
and the position of the dataset information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the file name correction was done in #118 .
* refactor trans eval * fix lint * support online eval * fix lint * fix conflicts among infer and eval * fix lint * fix pr * fix configs * change default to domain b Co-authored-by: yangyifei <PJLAB\yangyifei@shai14001042l.pjlab.org>
Refactor Evaluation for translation models.