Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update the installation of MMCV #245

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

LeoXing1996
Copy link
Collaborator

@LeoXing1996 LeoXing1996 commented Feb 9, 2022

mmcv-full is only compiled on PyTorch 1.x.0 because the compatibility usually holds between 1.x.0 and 1.x.1. If your PyTorch version is 1.x.1, you can install mmcv-full compiled with PyTorch 1.x.0 and it usually works well.

Related PR: open-mmlab/mmtracking#409

@LeoXing1996 LeoXing1996 changed the title [Enhancement] Upgrade isort in pre-commit hook [Enhancement] Update the installation of MMCV Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #245 (e3e9dff) into master (48c5b86) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files         134      134           
  Lines        9633     9633           
  Branches     1931     1931           
=======================================
  Hits         7345     7345           
  Misses       1822     1822           
  Partials      466      466           
Flag Coverage Δ
unittests 76.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c5b86...e3e9dff. Read the comment docs.

@LeoXing1996 LeoXing1996 merged commit d822904 into open-mmlab:master Feb 9, 2022
LeoXing1996 pushed a commit to LeoXing1996/mmgeneration that referenced this pull request Oct 27, 2022
* Add BasicVSR

* fix isort

* fix isort

* rename to basicvsr_net.py

* change step_counter to a key in train_cfg

* rename and fix minor bug

* rename to BasicVSRNet

* Fix init and model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant