fix #630: Added exception when receiving empty image

open-mmlab · Dec 1, 2021 · 3ea6282 · 3ea6282
1 parent 785b268
commit 3ea6282
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/mmocr/apis/inference.py b/mmocr/apis/inference.py
@@ -98,10 +98,8 @@ def model_inference(model,
 
     if isinstance(imgs, (list, tuple)):
         is_batch = True
-        if not len(imgs):
-            if not return_data:
-                return []
-            return [], []
+        if len(imgs) == 0:
+            raise Exception('empty imgs provided, please check and try again')
         if not isinstance(imgs[0], (np.ndarray, str)):
             raise AssertionError('imgs must be strings or numpy arrays')
 

diff --git a/tests/test_apis/test_model_inference.py b/tests/test_apis/test_model_inference.py
@@ -113,6 +113,9 @@ def test_model_batch_inference_empty_detection(cfg_file):
     model = build_model(config_file)
 
     empty_detection = []
-    results = model_inference(model, empty_detection, batch_mode=True)
 
-    assert len(results) == 0
+    with pytest.raises(
+            Exception,
+            match='empty imgs provided, please check and try again'):
+
+        model_inference(model, empty_detection, batch_mode=True)