Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): typo #1024

Merged
merged 3 commits into from
May 24, 2022
Merged

fix(docs): typo #1024

merged 3 commits into from
May 24, 2022

Conversation

tpoisonooo
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

model config link 404 error.

Modification

fix-typo.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented May 19, 2022

CLA assistant check
All committers have signed the CLA.

@xinke-wang
Copy link
Collaborator

Hi, thank you for your contribution! Could you kindly sign the CLA shown on this pr so we can accept the contribution.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1024 (9c1540c) into main (13986f4) will not change coverage.
The diff coverage is n/a.

❗ Current head 9c1540c differs from pull request most recent head 3f2f9ab. Consider uploading reports for the commit 3f2f9ab to get more accurate results

@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   83.77%   83.77%           
=======================================
  Files         170      170           
  Lines       11374    11374           
  Branches     1750     1750           
=======================================
  Hits         9528     9528           
  Misses       1468     1468           
  Partials      378      378           
Flag Coverage Δ
unittests 83.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13986f4...3f2f9ab. Read the comment docs.

@tpoisonooo
Copy link
Contributor Author

Hi, thank you for your contribution! Could you kindly sign the CLA shown on this pr so we can accept the contribution.

done.

Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! But these changes are not effective on readthedocs (https://mmocr--1024.org.readthedocs.build/en/1024/textdet_models.html#panet), and we can replace them with the full links instead.

configs/textdet/panet/README.md Outdated Show resolved Hide resolved
configs/textdet/panet/README.md Outdated Show resolved Hide resolved
tpoisonooo and others added 2 commits May 23, 2022 11:27
Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
@tpoisonooo
Copy link
Contributor Author

done.

@gaotongxiao
Copy link
Collaborator

Thanks!

@gaotongxiao gaotongxiao merged commit 4269957 into open-mmlab:main May 24, 2022
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* Update README.md

* Update configs/textdet/panet/README.md

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>

* Update configs/textdet/panet/README.md

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* Update README.md

* Update configs/textdet/panet/README.md

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>

* Update configs/textdet/panet/README.md

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>

Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants