-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): typo #1024
fix(docs): typo #1024
Conversation
Hi, thank you for your contribution! Could you kindly sign the CLA shown on this pr so we can accept the contribution. |
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 83.77% 83.77%
=======================================
Files 170 170
Lines 11374 11374
Branches 1750 1750
=======================================
Hits 9528 9528
Misses 1468 1468
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! But these changes are not effective on readthedocs (https://mmocr--1024.org.readthedocs.build/en/1024/textdet_models.html#panet), and we can replace them with the full links instead.
Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
done. |
Thanks! |
* Update README.md * Update configs/textdet/panet/README.md Co-authored-by: Tong Gao <gaotongxiao@gmail.com> * Update configs/textdet/panet/README.md Co-authored-by: Tong Gao <gaotongxiao@gmail.com> Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
* Update README.md * Update configs/textdet/panet/README.md Co-authored-by: Tong Gao <gaotongxiao@gmail.com> * Update configs/textdet/panet/README.md Co-authored-by: Tong Gao <gaotongxiao@gmail.com> Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
model config link 404 error.
Modification
fix-typo.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: