-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible ways of getting file name #1107
Conversation
Address issue #1078
Hi, thank you for your contribution. The current PR failed to pass our lint test. You may follow the instruction here to install pre-commit hook, so it will automatically format your code to meet our code style. |
Currently, I only able to work using |
Codecov Report
@@ Coverage Diff @@
## main #1107 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 170 170
Lines 11372 11372
Branches 1750 1750
=======================================
Hits 9526 9526
Misses 1468 1468
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
* Flexible ways of getting file name Address issue open-mmlab#1078 * fix lint Co-authored-by: gaotongxiao <gaotongxiao@gmail.com>
* Flexible ways of getting file name Address issue open-mmlab#1078 * fix lint Co-authored-by: gaotongxiao <gaotongxiao@gmail.com>
balandongiv,您好!您在MMOCR项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。 Hi @balandongiv !First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Address issue #1078
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: