Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible ways of getting file name #1107

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Flexible ways of getting file name #1107

merged 2 commits into from
Jul 4, 2022

Conversation

balandongiv
Copy link
Contributor

Address issue #1078

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@xinke-wang
Copy link
Collaborator

Hi, thank you for your contribution. The current PR failed to pass our lint test. You may follow the instruction here to install pre-commit hook, so it will automatically format your code to meet our code style.

@balandongiv
Copy link
Contributor Author

Currently, I only able to work using colab and made changes directly via Github website hence unable to install any package. Will do the necessary once I back to office 😇

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1107 (4a5d0da) into main (72a79f9) will not change coverage.
The diff coverage is n/a.

❗ Current head 4a5d0da differs from pull request most recent head 63f9f4f. Consider uploading reports for the commit 63f9f4f to get more accurate results

@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files         170      170           
  Lines       11372    11372           
  Branches     1750     1750           
=======================================
  Hits         9526     9526           
  Misses       1468     1468           
  Partials      378      378           
Flag Coverage Δ
unittests 83.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a79f9...63f9f4f. Read the comment docs.

@gaotongxiao gaotongxiao merged commit 7800e13 into open-mmlab:main Jul 4, 2022
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* Flexible ways of getting file name

Address issue open-mmlab#1078

* fix lint

Co-authored-by: gaotongxiao <gaotongxiao@gmail.com>
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* Flexible ways of getting file name

Address issue open-mmlab#1078

* fix lint

Co-authored-by: gaotongxiao <gaotongxiao@gmail.com>
@yaqi0510
Copy link

yaqi0510 commented Apr 3, 2023

balandongiv,您好!您在MMOCR项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。
我们非常期待与您继续合作,OpenMMLab专门成立了贡献者组织MMSIG,为贡献者们提供开源证书、荣誉体系和专享好礼,可通过添加微信:openmmlabwx 联系我们(请备注mmsig+GitHub id),由衷希望您能加入!

Hi @balandongiv !First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants