Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tps config #135

Merged
merged 3 commits into from
May 12, 2021
Merged

Conversation

cuhk-hbsun
Copy link
Collaborator

No description provided.

@cuhk-hbsun cuhk-hbsun requested a review from innerlee April 28, 2021 08:10
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #135 (e1cafae) into main (18c54af) will decrease coverage by 1.51%.
The diff coverage is 100.00%.

❗ Current head e1cafae differs from pull request most recent head 624c28e. Consider uploading reports for the commit 624c28e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   81.81%   80.29%   -1.52%     
==========================================
  Files         107      107              
  Lines        6592     6526      -66     
  Branches      969      949      -20     
==========================================
- Hits         5393     5240     -153     
- Misses        958     1061     +103     
+ Partials      241      225      -16     
Flag Coverage Δ
unittests 80.29% <100.00%> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../models/textrecog/preprocessor/tps_preprocessor.py 100.00% <100.00%> (ø)
mmocr/datasets/pipelines/dbnet_transforms.py 13.29% <0.00%> (-51.07%) ⬇️
mmocr/apis/inference.py 89.47% <0.00%> (-1.84%) ⬇️
mmocr/datasets/pipelines/box_utils.py 90.69% <0.00%> (-1.62%) ⬇️
mmocr/models/textrecog/recognizer/base.py 54.43% <0.00%> (-1.53%) ⬇️
mmocr/core/visualize.py 91.10% <0.00%> (-1.32%) ⬇️
mmocr/datasets/utils/loader.py 98.00% <0.00%> (-0.19%) ⬇️
...s/textrecog/recognizer/encode_decode_recognizer.py 92.77% <0.00%> (ø)
mmocr/datasets/kie_dataset.py 89.28% <0.00%> (+1.05%) ⬆️
mmocr/datasets/pipelines/kie_transforms.py 36.36% <0.00%> (+1.58%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c54af...624c28e. Read the comment docs.

@cuhk-hbsun cuhk-hbsun force-pushed the hbsun/refactor_tps branch from e1cafae to 624c28e Compare May 12, 2021 05:19
@@ -26,7 +26,7 @@
img_size=(32, 100),
rectified_img_size=(32, 100),
num_img_channel=1),
backbone=dict(type='VeryDeepVgg', leakyRelu=False, input_channels=1),
backbone=dict(type='VeryDeepVgg', leaky_relu=False, input_channels=1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here is a missing item in the previous refactor. Are there any more items missed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done in a separate pr

@cuhk-hbsun cuhk-hbsun merged commit df5493a into open-mmlab:main May 12, 2021
quincylin1 pushed a commit to quincylin1/mmocr-1 that referenced this pull request May 12, 2021
* refactor tps config

* recover tps

* add ckpt of tps
quincylin1 pushed a commit to quincylin1/mmocr-1 that referenced this pull request May 17, 2021
* refactor tps config

* recover tps

* add ckpt of tps
gaotongxiao pushed a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* refactor tps config

* recover tps

* add ckpt of tps
gaotongxiao pushed a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* refactor tps config

* recover tps

* add ckpt of tps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants