[Feature] Add svtr encoder #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaotongxiao
force-pushed
the
add_svtr_backbone
branch
from
aadaafd to
e967aa2
Compare
gaotongxiao
force-pushed
the
add_svtr_backbone
branch
from
e967aa2 to
a45f11e
Compare
Harold-lkk
reviewed
Dec 27, 2022
| def __init__(self, | ||
| embed_dims: int, | ||
| num_heads: int = 8, | ||
| mixer: str = 'Global', |
There was a problem hiding this comment.
global / local
global is never used, and the parameter can be changed to whether_local
There was a problem hiding this comment.
It's okay to keep the name consistent with paper
Comment on lines
566
to
578
| self.apply(self._init_weights) | ||
|
|
||
| def _init_weights(self, m): | ||
| if isinstance(m, nn.Linear): | ||
| trunc_normal_init(m.weight, mean=0, std=0.02) | ||
| if isinstance(m, nn.Linear) and m.bias is not None: | ||
| nn.init.zeros_(m.bias) | ||
| if isinstance(m, nn.LayerNorm): | ||
| nn.init.zeros_(m.bias) | ||
| nn.init.ones_(m.weight) | ||
| if isinstance(m, nn.Conv2d): | ||
| nn.init.kaiming_normal_( | ||
| m.weight, mode='fan_out', nonlinearity='relu') |
There was a problem hiding this comment.
remove and init with init_cfg
Harold-lkk
reviewed
Dec 29, 2022
Harold-lkk
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: