Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support auto import modules from registry. #1731

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

Harold-lkk
Copy link
Collaborator

Motivation

The registry now supports auto-import modules from the given location.

register_all_modules before running is no longer needed. The modules will be lazy-imported during building.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 88.32% // Head: 88.21% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (a757c1b) compared to base (f820470).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a757c1b differs from pull request most recent head 9fa97fa. Consider uploading reports for the commit 9fa97fa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1731      +/-   ##
===========================================
- Coverage    88.32%   88.21%   -0.11%     
===========================================
  Files          176      176              
  Lines        10919    10932      +13     
  Branches      1533     1536       +3     
===========================================
  Hits          9644     9644              
- Misses         993     1007      +14     
+ Partials       282      281       -1     
Flag Coverage Δ
unittests 88.21% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/apis/inferencers/base_mmocr_inferencer.py 89.47% <100.00%> (+0.11%) ⬆️
mmocr/datasets/transforms/formatting.py 99.12% <100.00%> (+0.10%) ⬆️
mmocr/registry.py 100.00% <100.00%> (ø)
mmocr/utils/setup_env.py 19.04% <0.00%> (-61.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit 1127240 into open-mmlab:dev-1.x Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants