Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bezier_to_polygon -> bezier2polygon #1739

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

double22a
Copy link
Contributor

@double22a double22a commented Feb 20, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2023

CLA assistant check
All committers have signed the CLA.

@gaotongxiao
Copy link
Collaborator

gaotongxiao commented Feb 20, 2023

Hi, thanks for your contribution! Before we are able to merge your PR, please don't forget to sign CLA here :)

image

Also, the linting test seems not passed.

image

You can install pre-commit hooks to automatically fix this issue:

pip install -U pre-commit
pre-commit install
pre-commit run --all-files
git add --update
git commit

@double22a double22a changed the title bezier_to_polygon -> bezier2polygon bezier_to_polygon -> bezier2polygon Feb 21, 2023
@double22a double22a closed this Feb 21, 2023
@double22a double22a deleted the patch-1 branch February 21, 2023 09:35
@double22a double22a restored the patch-1 branch February 21, 2023 09:36
@double22a double22a reopened this Feb 21, 2023
@double22a
Copy link
Contributor Author

double22a commented Feb 21, 2023

#!/bin/bash -eo pipefail
pre-commit run --all-files
[INFO] Initializing environment for https://github.com/PyCQA/flake8.
[INFO] Initializing environment for https://github.com/PyCQA/isort.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-yapf.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/executablebooks/mdformat.
[INFO] Initializing environment for https://github.com/executablebooks/mdformat:linkify-it-py,mdformat-openmmlab,mdformat_frontmatter.
[INFO] Initializing environment for https://github.com/myint/docformatter.
[INFO] Initializing environment for https://github.com/open-mmlab/pre-commit-hooks.
[INFO] Installing environment for https://github.com/PyCQA/flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/circleci/.cache/pre-commit/repougtuvw0p/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
Processing /home/circleci/.cache/pre-commit/repougtuvw0p
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'error'

stderr:
error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      Traceback (most recent call last):
        File "/home/circleci/.cache/pre-commit/repougtuvw0p/py_env-python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/circleci/.cache/pre-commit/repougtuvw0p/py_env-python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/circleci/.cache/pre-commit/repougtuvw0p/py_env-python3/lib/python3.7/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/tmp/pip-build-env-t3kpord9/overlay/lib/python3.7/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
        File "/tmp/pip-build-env-t3kpord9/overlay/lib/python3.7/site-packages/poetry/core/factory.py", line 57, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
      
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Check the log at /home/circleci/.cache/pre-commit/pre-commit.log

Exited with code exit status 3
CircleCI received exit code 3

@gaotongxiao
Copy link
Collaborator

It's okay - just a bug of MMOCR 1.x, which has been fixed in dev-1.x branch. I'll merge this PR to dev-1.x branch, and it would eventually be updated to 1.x branch when MMOCR 1.0.0rc6 releases.

@gaotongxiao gaotongxiao changed the base branch from 1.x to dev-1.x February 21, 2023 11:15
@gaotongxiao gaotongxiao merged commit 280a89c into open-mmlab:dev-1.x Feb 21, 2023
@double22a double22a deleted the patch-1 branch February 22, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants