Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] add opendatalab download link #1753

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

jorie-peng
Copy link
Contributor

add opendatalab download link in dataset_prepare docs, including:

  • docs/en/user_guides/data_prepare/dataset_preparer.md
  • docs/en/user_guides/data_prepare/det.md
  • docs/en/user_guides/data_prepare/recog.md
  • docs/zh_cn/user_guides/data_prepare/dataset_preparer.md
  • docs/zh_cn/user_guides/data_prepare/det.md
  • docs/zh_cn/user_guides/data_prepare/recog.md

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023

CLA assistant check
All committers have signed the CLA.

@jorie-peng jorie-peng changed the title Branch jiahui dev 1.x [Doc] add opendatalab download link Mar 1, 2023
gaotongxiao
gaotongxiao previously approved these changes Mar 8, 2023
@gaotongxiao
Copy link
Collaborator

Thanks for your contribution! The linting test seems not passed.

image

You can install pre-commit hooks to automatically fix this issue:

pip install -U pre-commit
pre-commit install
pre-commit run --all-files
git add --update
git commit

@gaotongxiao gaotongxiao self-requested a review March 8, 2023 08:56
@gaotongxiao gaotongxiao dismissed their stale review March 8, 2023 08:56

did not pass linting test

@jorie-peng
Copy link
Contributor Author

Thanks for your contribution! The linting test seems not passed.

image

You can install pre-commit hooks to automatically fix this issue:

pip install -U pre-commit
pre-commit install
pre-commit run --all-files
git add --update
git commit

Thanks for your help. I have checked it and push it again!

@gaotongxiao gaotongxiao force-pushed the Branch_jiahui-dev-1.x branch from 89b61b9 to 28627cb Compare March 14, 2023 07:32
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (47f5430) 89.89% compared to head (9039a5b) 89.89%.

❗ Current head 9039a5b differs from pull request most recent head a29dcb7. Consider uploading reports for the commit a29dcb7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1753   +/-   ##
========================================
  Coverage    89.89%   89.89%           
========================================
  Files          191      191           
  Lines        11197    11197           
  Branches      1578     1578           
========================================
  Hits         10065    10065           
  Misses         821      821           
  Partials       311      311           
Flag Coverage Δ
unittests 89.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit 7ef34c4 into open-mmlab:dev-1.x Mar 14, 2023
@jason102811
Copy link

Hi @jorie-peng !First of all, we want to express our gratitude for your significant PR in the MMOCR . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants