Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Deprecate file_client_args and use backend_args instead #1765

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

gaotongxiao
Copy link
Collaborator

Upgrade to use the new MMEngine interface. This upgrade requires mmcv >= 2.0.0rc4, which is already required by 1.0.0rc6.

Motivation

Use the new interface of fileio from MMEngine which requires mmengine>=0.2.0.
Refer to open-mmlab/mmcv#2468, open-mmlab/mmcv#2539

mmcv<2.0.0rc4: need to set the file_client_args to indicate the backend, if the file_client_args is None, the default option will be disk backend.
mmcv>=2.0.0rc4 : The function in fileio from MMEngine will automatically deal with different backends according to the prefix of data_root, if parameter backend_args is None

Reference

open-mmlab/mmselfsup#662

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 30.97% and project coverage change: -0.60 ⚠️

Comparison is base (33cbc9b) 90.30% compared to head (251627f) 89.70%.

❗ Current head 251627f differs from pull request most recent head 5cc8513. Consider uploading reports for the commit 5cc8513 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1765      +/-   ##
===========================================
- Coverage    90.30%   89.70%   -0.60%     
===========================================
  Files          189      190       +1     
  Lines        11093    11186      +93     
  Branches      1563     1578      +15     
===========================================
+ Hits         10017    10034      +17     
- Misses         769      841      +72     
- Partials       307      311       +4     
Flag Coverage Δ
unittests 89.70% <30.97%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...atasets/preparers/obtainers/naive_data_obtainer.py 16.82% <ø> (ø)
...ecog/recognizers/encoder_decoder_recognizer_tta.py 100.00% <ø> (ø)
mmocr/datasets/preparers/dumpers/lmdb_dumper.py 21.33% <21.33%> (ø)
mmocr/datasets/transforms/loading.py 88.70% <33.33%> (-7.60%) ⬇️
mmocr/datasets/preparers/config_generators/base.py 75.00% <37.50%> (-7.50%) ⬇️
...rs/config_generators/textrecog_config_generator.py 100.00% <100.00%> (ø)
mmocr/datasets/recog_text_dataset.py 100.00% <100.00%> (ø)
mmocr/engine/hooks/visualization_hook.py 92.30% <100.00%> (+3.67%) ⬆️
mmocr/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit 9caacc7 into open-mmlab:dev-1.x Mar 20, 2023
@gaotongxiao gaotongxiao deleted the filio branch March 20, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants