Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Preparer] MJSynth #1791

Merged
merged 2 commits into from
Mar 22, 2023
Merged

[Dataset Preparer] MJSynth #1791

merged 2 commits into from
Mar 22, 2023

Conversation

gaotongxiao
Copy link
Collaborator

This PR also modifies the way ICDARTxtTextRecogAnnParser generates img_path, which would not affect the existing implementations through testing.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (d80df99) 89.35% compared to head (fb70345) 89.36%.

❗ Current head fb70345 differs from pull request most recent head 985d07b. Consider uploading reports for the commit 985d07b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1791   +/-   ##
========================================
  Coverage    89.35%   89.36%           
========================================
  Files          192      192           
  Lines        11278    11279    +1     
  Branches      1596     1596           
========================================
+ Hits         10078    10079    +1     
  Misses         886      886           
  Partials       314      314           
Flag Coverage Δ
unittests 89.36% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...atasets/preparers/obtainers/naive_data_obtainer.py 16.21% <0.00%> (ø)
...ocr/datasets/preparers/packers/textrecog_packer.py 81.53% <100.00%> (+0.28%) ⬆️
...ocr/datasets/preparers/parsers/icdar_txt_parser.py 79.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit d0dc902 into open-mmlab:dev-1.x Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants