[Fix] fix converting to onnx bug because of changing key from img_shape to resize_shape #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
==========================================
- Coverage 85.69% 85.65% -0.04%
==========================================
Files 142 142
Lines 9539 9543 +4
Branches 1364 1364
==========================================
Hits 8174 8174
- Misses 1048 1052 +4
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaotongxiao
reviewed
Oct 12, 2021
There was a problem hiding this comment.
LGTM, ping @AllentDan Could you check if this change would incur any potential risks on deployment tasks?
AllentDan
reviewed
Oct 13, 2021
AllentDan
reviewed
Oct 20, 2021
gaotongxiao
reviewed
Oct 20, 2021
Comment on lines
+187
to
+188
| 1: 'seq_len', | ||
| 2: 'num_classes' |
There was a problem hiding this comment.
What are these keys for?
gaotongxiao
approved these changes
Oct 20, 2021
gaotongxiao
pushed a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
…pe to resize_shape (open-mmlab#523) * fix pytorch to onnx for mmocr0.3.0 * fix pytorch to onnx for mmocr0.3.0 * modify deployment doc and fix scale_factor bug and test psenet and panet * fix trt part * init detector with **(cfg.model) Co-authored-by: AllentDan <AllentDan@yeah.net>
gaotongxiao
pushed a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
…pe to resize_shape (open-mmlab#523) * fix pytorch to onnx for mmocr0.3.0 * fix pytorch to onnx for mmocr0.3.0 * modify deployment doc and fix scale_factor bug and test psenet and panet * fix trt part * init detector with **(cfg.model) Co-authored-by: AllentDan <AllentDan@yeah.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #407, in meta_keys, the img_shape was replaced by resize_shape, which causes failure on converting CRNN to ONNX.