Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Avoid dupliate placeholder docs in CN #582

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

gaotongxiao
Copy link
Collaborator

@gaotongxiao gaotongxiao commented Nov 12, 2021

Motivation

In the past, to maintain the structure of Chinese docs, we have to manually sync markdowns with EN docs. It's troublesome and introduces many duplicated markdowns in practice.

Modifications

  1. Add cp_origin_docs.sh to docs_zh_CN which copies all non-translated *.md files from EN docs to CN docs when building CN docs.
  2. Remove duplicated placeholder docs in CN directory.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #582 (57bb529) into main (c39f116) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   84.95%   84.95%           
=======================================
  Files         143      143           
  Lines        9796     9796           
  Branches     1414     1414           
=======================================
  Hits         8322     8322           
  Misses       1147     1147           
  Partials      327      327           
Flag Coverage Δ
unittests 84.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/models/textrecog/convertors/seg.py 91.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39f116...57bb529. Read the comment docs.

@cuhk-hbsun cuhk-hbsun merged commit dc6d957 into open-mmlab:main Nov 12, 2021
@gaotongxiao gaotongxiao deleted the cn_docs branch November 12, 2021 06:40
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* [Feature] Avoid dupliate placeholder docs in CN

* add changelog to cn docs
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
* [Feature] Avoid dupliate placeholder docs in CN

* add changelog to cn docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants