Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Pass custom_hooks to MMCV #609

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

gaotongxiao
Copy link
Collaborator

Modifications

Transfer the processing steps of custom_hooks to MMCV.

BC Breaking

None. MMCV 1.3.4 started to support this argument whereas MMOCR's minimum version requirement is 1.3.8.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #609 (3387b4b) into main (53b050b) will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   84.86%   84.93%   +0.07%     
==========================================
  Files         143      143              
  Lines        9816     9806      -10     
  Branches     1420     1418       -2     
==========================================
- Hits         8330     8329       -1     
+ Misses       1158     1149       -9     
  Partials      328      328              
Flag Coverage Δ
unittests 84.93% <50.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/apis/train.py 17.64% <50.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b050b...3387b4b. Read the comment docs.

@gaotongxiao gaotongxiao merged commit 1c8ab80 into open-mmlab:main Nov 30, 2021
@gaotongxiao gaotongxiao deleted the custom_hook branch November 30, 2021 07:10
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
gaotongxiao added a commit to gaotongxiao/mmocr that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants