[Refactor] refactor transformer modules #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 84.92% 85.22% +0.30%
==========================================
Files 143 145 +2
Lines 9810 9856 +46
Branches 1469 1482 +13
==========================================
+ Hits 8331 8400 +69
+ Misses 1150 1128 -22
+ Partials 329 328 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cuhk-hbsun
force-pushed
the
hbsun/nrtr
branch
from
f176748 to
dea18de
Compare
gaotongxiao
reviewed
Dec 1, 2021
gaotongxiao
reviewed
Dec 1, 2021
cuhk-hbsun
force-pushed
the
hbsun/nrtr
branch
from
58ed483 to
21ed095
Compare
gaotongxiao
reviewed
Dec 3, 2021
gaotongxiao
approved these changes
Dec 3, 2021
mmocr/apis/inference.py
Outdated
Comment on lines
75
to
105
| dataset_type = cfg.data[set_type].type | ||
| if dataset_type in ['OCRDataset', 'OCRSegDataset']: | ||
| if cfg.data[set_type].pipeline[1].type == 'MultiRotateAugOCR': | ||
| warnings.warn(warning_msg) | ||
| cfg.data[set_type].pipeline = [ | ||
| cfg.data[set_type].pipeline[0], | ||
| *cfg.data[set_type].pipeline[1].transforms | ||
| ] | ||
| elif dataset_type == 'ConcatDataset': | ||
| for dataset in cfg.data[set_type].datasets: | ||
| if dataset.pipeline[1].type == 'MultiRotateAugOCR': | ||
| warnings.warn(warning_msg) | ||
| dataset.pipeline = [ | ||
| dataset.pipeline[0], *dataset.pipeline[1].transforms | ||
| ] | ||
| elif dataset_type == 'UniformConcatDataset': | ||
| uniform_pipeline = cfg.data[set_type].pipeline | ||
| if uniform_pipeline is not None: | ||
| if uniform_pipeline[1].type == 'MultiRotateAugOCR': | ||
| warnings.warn(warning_msg) | ||
| cfg.data[set_type].pipeline = [ | ||
| uniform_pipeline[0], *uniform_pipeline[1].transforms | ||
| ] | ||
| for dataset in cfg.data[set_type].datasets: | ||
| if dataset.pipeline is not None: | ||
| if dataset.pipeline[1].type == 'MultiRotateAugOCR': | ||
| warnings.warn(warning_msg) | ||
| dataset.pipeline = [ | ||
| dataset.pipeline[0], | ||
| *dataset.pipeline[1].transforms | ||
| ] |
There was a problem hiding this comment.
It's okay but also a bit ugly. @Harold-lkk any refactor suggestion?
gaotongxiao
pushed a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
* base refactor * update config * modify implementation of nrtr * add config file * add mask * add operation order * fix contiguous bug * update config * fix pytest * fix pytest * update readme * update readme and metafile * update docstring * fix norm cfg and dict size * rm useless * use mmocr builder instead * update pytest * update * remove useless * fix ckpt name * fix path * include all config file into pytest * update inference * Update test_recog_config.py
gaotongxiao
pushed a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
* base refactor * update config * modify implementation of nrtr * add config file * add mask * add operation order * fix contiguous bug * update config * fix pytest * fix pytest * update readme * update readme and metafile * update docstring * fix norm cfg and dict size * rm useless * use mmocr builder instead * update pytest * update * remove useless * fix ckpt name * fix path * include all config file into pytest * update inference * Update test_recog_config.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
models/commonNRTRmodel