Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bug in non-distributed multi-gpu training/testing #1156

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Jan 26, 2022

Motivation

Refer to open-mmlab/mmdetection#7019

For training, we use single gpu in non-distributed env like in mmdet#7019. For testing, we add --gpu-id argument to allow specifying the device, instead of using gpu-0 by force.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 requested a review from jin-s13 January 26, 2022 09:59
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jin-s13
✅ ly015
❌ Canwang-sjtu
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev-0.23@19a43c4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev-0.23    #1156   +/-   ##
===========================================
  Coverage            ?   82.46%           
===========================================
  Files               ?      203           
  Lines               ?    16101           
  Branches            ?     2873           
===========================================
  Hits                ?    13278           
  Misses              ?     2095           
  Partials            ?      728           
Flag Coverage Δ
unittests 82.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a43c4...235a0c4. Read the comment docs.

@ly015 ly015 changed the base branch from master to dev-0.23 January 26, 2022 10:22
@ly015 ly015 merged commit 6adcf9e into open-mmlab:dev-0.23 Jan 26, 2022
ly015 added a commit to ly015/mmpose that referenced this pull request Feb 11, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants