Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent between docs and demo code #121

Merged
merged 1 commit into from
Sep 3, 2020
Merged

consistent between docs and demo code #121

merged 1 commit into from
Sep 3, 2020

Conversation

zhouhang95
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          83       83           
  Lines        4685     4685           
  Branches      822      822           
=======================================
  Hits         3786     3786           
  Misses        761      761           
  Partials      138      138           
Flag Coverage Δ
#unittests 80.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c264b01...5e5a680. Read the comment docs.

@jin-s13
Copy link
Collaborator

jin-s13 commented Sep 3, 2020

Thanks!
Maybe out-video-root is a better name.

docs/getting_started.md Outdated Show resolved Hide resolved
@zhouhang95 zhouhang95 closed this Sep 3, 2020
@zhouhang95 zhouhang95 reopened this Sep 3, 2020
@innerlee
Copy link
Contributor

innerlee commented Sep 3, 2020

We can make the scripts more consistent by imposing this abc-def-gh convention on all scripts in tools folder. like here https://github.com/open-mmlab/mmpose/blob/master/tools/test.py#L28

it can be done in a separate pr

@innerlee innerlee merged commit d1ed34f into open-mmlab:master Sep 3, 2020
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* [Refactor]: Change scheduler to param_scheduler

* [Fix]: Fix UT of param scheduler hook

Co-authored-by: Your <you@example.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants