Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support COCO-Wholebody #133

Merged
merged 12 commits into from
Sep 19, 2020
Merged

Support COCO-Wholebody #133

merged 12 commits into from
Sep 19, 2020

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Sep 18, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #133 into master will decrease coverage by 0.77%.
The diff coverage is 60.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   82.26%   81.49%   -0.78%     
==========================================
  Files          84       85       +1     
  Lines        4871     4976     +105     
  Branches      857      870      +13     
==========================================
+ Hits         4007     4055      +48     
- Misses        713      767      +54     
- Partials      151      154       +3     
Flag Coverage Δ
#unittests 81.49% <60.27%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/apis/inference.py 71.53% <0.00%> (-5.64%) ⬇️
mmpose/datasets/__init__.py 100.00% <ø> (ø)
mmpose/datasets/datasets/__init__.py 100.00% <ø> (ø)
...datasets/datasets/top_down/topdown_coco_dataset.py 63.73% <0.00%> (ø)
...atasets/top_down/topdown_coco_wholebody_dataset.py 64.92% <64.92%> (ø)
mmpose/datasets/datasets/top_down/__init__.py 100.00% <100.00%> (ø)
mmpose/models/detectors/base.py 36.73% <0.00%> (-5.86%) ⬇️
mmpose/datasets/dataset_wrappers.py 50.00% <0.00%> (-4.55%) ⬇️
mmpose/datasets/pipelines/loading.py 85.71% <0.00%> (-0.96%) ⬇️
mmpose/datasets/pipelines/top_down_transform.py 79.87% <0.00%> (-0.74%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4229e92...41df91d. Read the comment docs.


return rec

def _coco_keypoint_results_one_category_kernel(self, data_pack):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the test coverage of this function is low

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the 'unit-test for dataset testing' in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine


return cat_results

def _do_python_keypoint_eval(self, res_file):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@innerlee innerlee merged commit 0d2568d into master Sep 19, 2020
@innerlee innerlee deleted the wholebody branch September 19, 2020 05:18
@innerlee
Copy link
Contributor

need a pr to update repo's readme, and the change log

shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants