Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] replace markdownlint with mdformat for avoiding installing ruby #1382

Merged
merged 3 commits into from
May 19, 2022

Conversation

ly015
Copy link
Member

@ly015 ly015 commented May 18, 2022

Motivation

Ref: open-mmlab/mmcv#1936

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1382 (722d348) into master (f8b79fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         225      225           
  Lines       18997    18997           
  Branches     3392     3392           
=======================================
  Hits        15797    15797           
  Misses       2364     2364           
  Partials      836      836           
Flag Coverage Δ
unittests 83.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc3658...722d348. Read the comment docs.

@ly015 ly015 requested a review from jin-s13 May 18, 2022 18:48
@ly015 ly015 force-pushed the switch-to-mdformat branch from b638f8e to 722d348 Compare May 18, 2022 19:08
@ly015 ly015 merged commit 2130e08 into open-mmlab:master May 19, 2022
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
…ruby (open-mmlab#1382)

* switch to mdformat

* update docs

* update ci config
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
…ruby (open-mmlab#1382)

* switch to mdformat

* update docs

* update ci config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants