Fix warning with torch.meshgrid #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin-s13
reviewed
May 30, 2022
|
Refer to open-mmlab/mmdetection#8090 (comment) for discussion on PyTorch version support of |
ly015
reviewed
May 30, 2022
|
@pallgeuer Thank you very much for your help! |
pallgeuer
force-pushed
the
fix_torch_meshgrid
branch
from
d7ac45a to
2d19d9f
Compare
|
I have updated the pull request to now correctly deal with PyTorch versions above and below 1.10.0 using a wrapper. Can the PR be reviewed if all is well now? |
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 84.16% 84.34% +0.18%
==========================================
Files 232 232
Lines 19308 19279 -29
Branches 3472 3468 -4
==========================================
+ Hits 16250 16261 +11
+ Misses 2183 2152 -31
+ Partials 875 866 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ly015
approved these changes
Jun 3, 2022
This was referenced Jun 7, 2022
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 5, 2023
* Fix warning with torch.meshgrid * Add meshgrid wrapper that is sensitive to torch version * move misc.py from mmpose.utils to mmpose.model.utils Co-authored-by: ly015 <liyining0712@gmail.com>
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* Fix warning with torch.meshgrid * Add meshgrid wrapper that is sensitive to torch version * move misc.py from mmpose.utils to mmpose.model.utils Co-authored-by: ly015 <liyining0712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
torch.meshgrid()has started raising a warning when not called with an explicit indexing parameter:https://pytorch.org/docs/stable/generated/torch.meshgrid.html
Modification
Provide
indexing='ij'to all calls totorch.meshgridthat don't already specify indexing.Checklist
Before PR:
After PR: